Baccy tins* and Coleman''s Mustard tins are a sad loss 
Smith kendon travel sweet tins have their uses.
The tiny flip top tins used for posh mints come in handy for things like collecting together all the small screws when you dismantle the latest project.
A colleague who got addicted to sugar-free mints when he gave up smoking gave me enough flip-lid oval-section metal tins for all my 1/4 watt resistors.
The ambassador's Ferrero Roche boxes are a handy size for storing small parts.
The big flat metal biscuit tins (not deep chocolate tins) are useful for storage, I use one for all my odd bits fof brass etc. They can also be a source of useful metal sheet (the top of the bonnet of my shunter when I ran out of brass).
Plastic crates are great for storing untidy things like power tools, footpumps, music leads and power supllies etc.
The little sets of plastic drawers are great for small electrical components.
I have a set of 16 wooden drawers from a crafty shop, very cheap in unfinished limewood that got stained blue an never finished. ideal small tool chest. I think you are meant to paint hearts and flowers on them and fill them with girly stuff.
Boot sales can turn up all sorts of handy little containers, sometimes aalready filled with useful bits (or just rusty screws)/ I was given a little brass two-part case presumably meant for sewing needles. In it were a selection of tiny spade drills.
Neil
*Remember whenb you could always spot an old lag by the matchstick encrusted baccy tin?