Baz;
My last tender tanks were brass, angle, soldered with "plumbing solder". You have to watch, as the heat will distort flat surfaces, like the tender tank bottom.
I have never tinned the angle, just add flux with a brush, carefully heat, and let the solder run along. If you heat one side of the tender (the outside) and apply solder to the inside, you'll see it all go together well. The solder will flash along the angle, via capillary action, so you'll see it's progress.
But I like what Nick Feast did for his Q1 tender – glue it together! Find the articles and read them. I like the way Nick was thinking outside of the box when he made his Q1.
I think for one of my tenders, almost complete save for the soldering, I will seal it with a gasket material, not solder. We'll see what this winter brings, though…